On Tue 04 Mar 2008 at 07:19PM, Danek Duvall wrote:
> > Test changes exempt from review would only be in support of bugs which
> > are in the database (i.e. no adding failing test cases without associate
> > bugs). That is to say, you can't check in as follows:
>
> Missing something here?
Sorry, I did a lot of rewrite, and it was a long day. Sorry for
the incoherence. Now that I've had some wine, I don't think it's
the right moment for further revisions...
> > I would propose we copy the mozilla.org keyword "needtestcase" and
> > tag bugs which need test cases appropriately.
>
> Sounds good to me.
>
> I think this warrants a trial, at the very least.
>
> However, I think before we can institute this, the testsuite needs to
> support known failures. Otherwise it's going to be a royal pain in the
> butt to run the suite and see dozens of errors you're not fixing and you
> can't really do anything about.
I'm not clear whether I can do this without a substantial rewrite of
unittest. It may be possible, but I've avoided looking at the
implementation of unittest itself, in the event that I need to reauthor
something equivalent to it at some point. I'm obviously reluctant to do
major hacking on something like unittest...
Can you live with some inconvenience in the short term?
Is it OK, from a licensing perspective, to just take the code for
unittest and start hacking? (Perhaps we'll have to take that
off-alias). I did read the header comment, which says "...you may
redistribute it and/or modify it under the same terms as Python
itself..." but IANAL and I'm not sure what those terms are.
> > Comments, etc. appreciated. I'd like to get to consensus. Once
> > there, I'll then write this up and put it on the website (if someone
> > will give me write access to the project web).
>
> I've added you as a leader; you should be able to edit the site now.
Thanks,
-dp
--
Daniel Price - Solaris Kernel Engineering - [EMAIL PROTECTED] - blogs.sun.com/dp
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
