On Thu, Apr 03, 2008 at 03:15:46AM -0700, Dan Price wrote:
> http://cr.opensolaris.org/~dp/ips-cli-rewhack
client.py:
- line 229: Feel free to say "because it keeps biting us", but why not
just "if not args"?
- line 230: Use "list()" to cast to a list. I might suggest just setting
"fmris = image.gen_installed_pkgs()", but you do make some small
assumptions that it's a list in the places that installed_fmris_from_args()
is called.
- line 505: from where the search wad was ripped out?
- line 561: "kB".
- line 572: is this comment out of date?
- line 635, 637: why not just do the str() once on line 612?
- line 659: This will no longer ever be true, right?
- line 680: you don't need this any more.
- line 719: would this be any clearer?
if set(("-H", "-o", "-t")).intersection(set([x[0] for x in opts])):
I would at least replace the map with a list comprehension.
- line 725: probably should be dedented, maybe moved up above the loop.
- line 729: are these really violations that should print out a usage
message? There isn't any indication in the usage message what the
valid special attributes are.
- line 764: space after comma
pkg.1.txt:
- line 13: not your bug, but could you change "pkh" to "pkg" here? And
since you're in this file, could you also fix bug 970?
- line 99: period at end of sentence.
- line 116: period instead of semicolon. Or don't capitalize next word
(and make it consistent with the next paragraph).
- line 194: is ":NAME" still used as the header?
manifest.py:
- line 224: why the assert?
- line 254: "self.size += int(action.attrs.get("pkg.size", "0"))"
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
