On Wed, May 7, 2008 at 12:22 PM, Danek Duvall <[EMAIL PROTECTED]> wrote:
>     http://cr.opensolaris.org/~dduvall/pkg-bug225/
>
>  is a fix for
>
>     225 unneeded backtrace in server log on broken pipe

The change looks good to me as well.

However, I did wonder what the effective difference is from what you've done:

      121 +        except Exception, e:
      122 +                if isinstance(e, socket.error) and \
      123 +                    e.args[0] == errno.EPIPE:

and this found in module/server/face.py:
                except socket.error, e:
                        if e[0] != EPIPE:
                                request.log_error("Failed to serve %s: %s" % \
                                    (request.path_info, e[1]))

Cheers,
-- 
Shawn Walker

"To err is human -- and to blame it on a computer is even more so." -
Robert Orben
_______________________________________________
pkg-discuss mailing list
pkg-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to