This change looks fine to me. Thanks for doing this.
-j On Mon, May 26, 2008 at 10:16:17PM -0500, Shawn Walker wrote: > The following webrev includes proposed fixes for the following bugs: > > 2041 client performance hampered by unnecessary getpwuid/getgrgid calls > > webrev: > http://cr.opensolaris.org/~swalker/pkg-2041/ > > Notes: > Before this change dtrace had the following output for "pkg install SUNWvim" > in > an empty user image: > > dtrace -n 'syscall:::entry /execname == "client.py"/{ @num[probefunc] > = count(); }' > > ... > doorfs 9270 > getuid 11544 > ... > > After the change: > > doorfs 9268 > getuid 9424 > > We still have quite a few doorfs/getuid calls, but this change does help some. > > Tests seem to indicate this is the right change to make, though we > possibly have more to do (unrelated to tarfile). > > Cheers, > -- > Shawn Walker > > "To err is human -- and to blame it on a computer is even more so." - > Robert Orben > _______________________________________________ > pkg-discuss mailing list > [email protected] > http://mail.opensolaris.org/mailman/listinfo/pkg-discuss _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
