Looks good to me.
Tom
Shawn Walker wrote:
Tom and Bart, do you have any objections to the new changeset before I putback?
I just want to ensure I've addressed your previous concerns.
Thanks,
2008/6/2 <[EMAIL PROTECTED]>:
This looks fine to me.
-j
On Fri, May 30, 2008 at 05:25:21PM -0500, Shawn Walker wrote:
2008/5/30 Shawn Walker <[EMAIL PROTECTED]>:
2008/5/29 Shawn Walker <[EMAIL PROTECTED]>:
2008/5/29 <[EMAIL PROTECTED]>:
Hi Shawn,
Once in a while you'll see an error from the shell about resource
unavailable, but no python tracebacks best I can tell.
Somebody just filed this as 2083. Do you know if this is related to
SIGPIPE or something different? I haven't had a chance to debug this
yet, and the bug report lacked a fair amount of detail.
I have added a proposed fix for bug 2083 to this changeset since
interrupting the client causes this issue as well.
New webrev:
http://cr.opensolaris.org/~swalker/pkg-115-2/
diff since last webrev:
http://cr.opensolaris.org/~swalker/pkg-115-2/raw_files/pkg-115-2.patch
The solution was to use os._exit() when handling a KeyboardInterrupt
or PipeError and appears to be the result of Python's built-in
sys.exit behaviour:
http://docs.python.org/lib/module-exceptions.html#l2h-122
Thanks to Krister's further research last night, I know now for
certain that it was Python causing this message.
Since the new direction seems to be to file and fix this issue in
Python, and not in pkg, I will remove my workaround to suppress this
message later tonight and re-post the new webrev.
Per the earlier discussion, I have removed the workaround for bug 2083
as it is a Python bug, not a pkg bug.
I have also removed the unused "errno" import and added a clarifying
comment to the exception handling.
updated webrev:
http://cr.opensolaris.org/~swalker/pkg-115-3/
diff to prior webrev:
http://cr.opensolaris.org/~swalker/pkg-115-3/raw_files/pkg-115-3.patch
Cheers,
--
Shawn Walker
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
begin:vcard
fn:Tom Mueller
n:Mueller;Tom
org:Sun Microsystems, Inc.;SWI Install/Update Software
adr:;;21915 Hillandale Dr;Elkhorn;NE;68022;USA
email;internet:[EMAIL PROTECTED]
title:Senior Staff Engineer
tel;work:877-250-4011
tel;fax:877-250-4011
tel;home:402-916-9943
x-mozilla-html:TRUE
version:2.1
end:vcard
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
