* Michal Pryc <[EMAIL PROTECTED]> [2008-05-28 11:56]:
> Michal Pryc wrote:
>> Hello,
>> We have been discussing putting packagemanager code into the pkg tree:
>> http://mail.opensolaris.org/pipermail/pkg-discuss/2008-April/002780.html
>>
>> I have made changes which are available for review at:
>> http://cr.opensolaris.org/~migi/packagemanager-integration/
>>
>> This version of packagemanager is cleaned up source code, so only working
>> and integrated bits are there without any additional files which are in
>> the old repository.
>>
>> As we were discussing there is the following structure:
>> src
>> cmd
>> gui
>>
>>
>> So there is a space for:
>> src
>> cmd
>> cli
>>
>> I didn't touch anything from the current sources except one file
>> src/Makefile
>>
>> The following make commands works with the gui:
>>
>> make (this builds *pyc files for both cli and gui)
>> make install (this creates only cli package SUNWipkg)
>> make gui-install (this creates SUNWipkg-gui and SUNWipkg-gui-data)
>> make clean (cleans all source code together with gui)
>>
>> Any comments welcome
I'm happy to get this in, but have a couple of questions/comments that
will need to be addressed post-integration:
0. Long term, what event-handling/multithreading/multiprocessing
model do you see packagemanager using? A big event loop for
everything, with single thread dispatch? With multiple thread
dispatch? Separate specific-purpose threads?
1. The separate implementations of
- filelist/0 in filelist.py
- install evaluation in installupdate.py
- uninstall evaluation in remove.py
all will need to be refactored away. If we need to support a
callback structure in pkg(5), or the commands need to have an XML
output mode, or whatever, that's fine. But algorithmic
duplication of this kind is unsafe--the lack of boot environment
support in packagemanager is an early example.
2. What Python style are you following? (Is there a PyGTK+ style
variant, or should we all settle on PEP 8 style? pkg(5) so far is
PEP 8, but with 8 space indentation.)
3. Tom is splitting the Makefile/setup.py structure in accordance
with the thread in
http://mail.opensolaris.org/pipermail/pkg-discuss/2008-May/003469.html
You'll want to think about how you plug in (and Tom might have
some ideas, since I know they use packagemanager, too).
If everyone could take a look at Michal's changes in the next day or
two, that would be helpful. I'd like to get this in this week.
- Stephen
--
[EMAIL PROTECTED] http://blogs.sun.com/sch/
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
