Sorry for the late review. On Thu, May 29, 2008 at 03:38:54PM -0700, Brock Pytlik wrote:
> webrev at: http://cr.opensolaris.org/~bpytlik/ips-fix-2085/ - There's no evaluation in the bug. What's the actual cause of the problem, and why do we need to move to generating the files at run-time instead of using the static ones in the gate? Could sys.path[0] be used to find the static files? - spaces after commas - The webrev doesn't indicate that you're getting rid of the files in the testdata directory (the checked-in ones); presumably they're not needed any more? - The string + variable + string constructions in the manifests are, IMHO, difficult to read. I'd use %s expandos instead. - You don't seem to do anything with "empty". Does that not cause problems, too? - Ditch the ident string in the ftpusers file. - line 139ff: Not a requirement, but I'd probably use eval here to reduce the elif cluster to a single line. Danek _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
