This is mostly style -- easy fixes to get your wad better in line with the rest of the gate. I'm happy to review the code itself, but I believe Stephen's goal is to get it into the IPS gate first, then start reworking the code, so I guess that review can wait. If either Stephen or you would like that review before the putback, let us know.
I'm not a fan of the "cmd" directory, at least not without reorganizing the rest of the gate to match, and I don't really want to (or see the need to) do that. I don't think there's a need for a separate gui-install target. Please get rid of ident strings and emacs hints (-*- coding: utf-8 -*-). I'll echo Shawn's quesion about keeping CDDL in a string, rather than in a comment. Spaces after commas, please. Spaces around binary operators. Eight-space indentation for normal lines, four spaces for continuation lines. In general, please copy the style of the rest of the gate. Please do the import lines without any decoration. I'll echo Stephen's comment about code duplication. Don't do that. "cancelled" is spelled with two "l"s. Please drop commented-out code. Please drop the "#-----..." comment before each method. In packages, please set BASEDIR to "/" and keep prototype files sorted by pathname. Thanks, Danek _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
