2008/6/16 Dan Price <[EMAIL PROTECTED]>: > On Mon 16 Jun 2008 at 12:44AM, Shawn Walker wrote: >> The following webrev includes proposed fixes for the following bugs: >> >> 2245 client - pylint cleanup needed > > 676, 684 & 686: it seems like fmri/mfmri could just be inlined as > mfst.fmri in the two places we use it, and line 676 deleted... it'd be > clearer IMO. > > i.e.: > > license.get_remote_opener(img, mfst.fmri)(), sys.stdout)
Agreed. I've changed this and now I'll do a putback. > Otherwise looks good to me. Thanks for doing the cleanup. Thanks to all for quickly reviewing this. Cheers, -- Shawn Walker _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
