On Mon, Jun 16, 2008 at 02:04:32PM -0700, [EMAIL PROTECTED] wrote:
> As requested, some high-level thoughts:
>
> * Would you comment the code that deals with the catalog cache more
> thoroughly? It took me a couple of passes to parse cache_fmri(), and
> even now, I don't understand why the structure is so complicated.
It's not particularly complicated, but divining the structure from the code
isn't the most straightforward thing. I'll definitely put a comment in.
The basic idea:
dict mapping pkg name to:
dict mapping version to:
tuple of fmri and a list of authorities
and the special key "version" to:
a sorted list of versions
> * If we're spending all of this effort to render the text-based catalog
> into an easily cachable binary format, why not just make the catalog a
> binary format and be done with it?
You mean, make the OTW catalog binary? Because then it'll be limited to
Python clients. Same with the on-disk format. Plus I'm not caching rename
records or attributes.
> * Why did you add the additional call to symlink in the install_file
> logic? A comment explaining this would be nice.
That's part of Stephen's code.
Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
