Shawn Walker wrote: > 2008/6/23 Brock Pytlik <[EMAIL PROTECTED]>: > >> Ok, so here's a summary of what I've heard so far: >> > > This looks right to me. > > When can we start? :-) > > Well, here's a webrev for the changed pylintrc file we're distributing. I find the refactoring guidelines to be silly and so I had it ignore those warnings. I also tweaked the regex's for a few names to match what we have in code (and to fix the problem that pylint seems to have different intuitions from mine about what a "constant" is). The module issues stem from our use of a different directory structure in src/modules than what we have in vendor-packages. I'm open to better solutions to this problem.
I've left the spacing at 8, as I didn't get a feel for whether we'd come to a consensus one way or the other on that issue. Also, although pylint doesn't check it (I don't think), we should also decide whether to stick with our current continuing line indentation or switch over to the PEP8 standards for that as well. We can make that change while remaining at 8 spaces, but changing to 4 spaces (I think) would mandate a change. Finally, I'll add one note about the 8 space issue: It's hard to meet the 80 character limit when your line starts by indenting 64 spaces in. Perhaps that means my code is poorly structured, but I think refactoring (or shortening names) to meet an indentation guideline, and only for that purpose, seems silly to me. Here's the webrev: http://cr.opensolaris.org/~bpytlik/ips-pylintrc/ Brock _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
