On Thu, Jun 26, 2008 at 05:29:11PM -0500, Tom Mueller (pkg-discuss) wrote:

> http://cr.opensolaris.org/~tmueller/cr-2209,2222,2343/

license.py

  - line 77: you're not actually making sure the directory is writable,
    just that it exists.  I'd change the comment to match the code.

  - line 80: this could be an "elif", as path couldn't exist if the
    directory hadn't previously.

Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to