On Thu, Jun 26, 2008 at 06:59:39PM -0500, Shawn Walker wrote: > 2008/6/18 Brad Hall <[EMAIL PROTECTED]>: > > Hi, > > > > The webrev below contains a proposed fix for: > > > > 1121 - normal user gets a traceback when running "pkg install <pkg>" from > > installed RC0 system > > > > Webrev: http://cr.opensolaris.org/~bgh/bug-1121/ > > http://cr.opensolaris.org/~bgh/bug-1121/src/modules/client/filelist.py.wdiff.html > ========== > 277 + os.makedirs(download_dir) > > Do you need set mode=xxx here? > > Otherwise, this change seems right to me. >
Thanks for reviewing. So it wasn't setting a mode before (that I can tell), and it looks like a lot of the other callers of os.makedirs() aren't setting a mode. I have no problem with setting it through, does 0755 sound reasonable? Thanks, Brad _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
