2008/6/29 Danek Duvall <[EMAIL PROTECTED]>: > On Sun, Jun 29, 2008 at 02:05:44PM -0500, Shawn Walker wrote: > >> Having just worked on the actions parsing for bug 2008, I think the >> single quotes are problematic. >> >> I'm fairly certain that using ' instead of " is going to cause the >> parsing to go bad if you have spaces. > > Obviously that has something to do with it, but the manifest that gets > written into the pkg directory in the repo is properly formed, with double > quotes. I've no idea how that's happening.
Do you think we should change it to allow quoting with ' instead of " as long as they start and end the attribute value that way? I don't think it would be difficult to change. I'll file a bug if you agree. > The code that's crashing is pulling that manifest off disk, so the server > failure shouldn't have anything to do with the quotes. I agree. > There's something seriously weird going on with the quoting -- why fixing > the quoting makes the problem go away doesn't make any sense to me, and > neither does the broken quoting mysteriously getting fixed. Completely agree. > On top of that, we could be better about catching KeyError exceptions in > generate_indices(), and be better about giving you a good error message > back at the commandline. That and better validation of the input for pkgsend. We definitely need less "mystery" during the publishing process. I'll file a bug for the last two things. -- Shawn Walker _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
