On Tue, Jul 15, 2008 at 01:09:30AM -0400, Dale Ghent wrote:

> http://cr.opensolaris.org/~daleg/defect-2009/

The logic looks fine, but please don't use regular expressions for this --
they're unnecessary, and slow in such a simple situation.  You'd be better
off with something like

    if line[0] in "+-":
        continue

I'd also put a comment in there explaining what the test is for.

Thanks,
Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to