Created issue 2721.

Tom


Danek Duvall wrote:
I'm sorry I didn't have a chance to review this.

Your use of a temporary fmri in the last hunk is unnecessary, and will slow
the operation down, at least a little bit.  You should create the fmri,
retrieve the authority, and call set_authority() on the original fmri
object.  That'll save us time on object creation and parsing, as well as
generally looking less messy.

A new bug to cover this will be fine.

Thanks,
Danek

begin:vcard
fn:Tom Mueller
n:Mueller;Tom
org:Sun Microsystems, Inc.;Update Center Software
adr:;;21915 Hillandale Dr;Elkhorn;NE;68022;USA
email;internet:[EMAIL PROTECTED]
title:Senior Staff Engineer
tel;work:877-250-4011
tel;fax:877-250-4011
tel;home:402-916-9943
x-mozilla-html:TRUE
version:2.1
end:vcard

_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to