On Fri, Aug 01, 2008 at 09:39:48AM -0500, Tom Mueller wrote: > Brad, > > Please consider these comments. > > 1. +1 on moving the memleaks to a separate target. > > 2. There is a similar code block at the top of setup.py and run.py that > detects the OS name/type. Maybe those blocks could be put into a shared > file (maybe testutil.py or maybe a new buildutil.py). > > 3. run.py, line 178: there is a portable.is_admin() method that tries to > do the right thing for other platforms. > > From a multi-platform perspective, I like how you've structured this. > I'm hoping that eventually we'll get the CLI tests to run on Windows > too, but we have some work in the depotcontroller to make that happen.
Good points, I'll fix those and send an updated webrev later today. Thanks for reviewing! -Brad _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
