Danek Duvall wrote: > On Fri, Aug 01, 2008 at 06:57:37PM -0700, Bart Smaalders wrote: > >> http://cr.opensolaris.org/~barts/2589/ > > .hgignore: > > - I wonder if perhaps we shouldn't have one pattern to eliminate all > prototype files?
Ok. > > file.py: > > - line 90: Now that you removed the setting of ohash, you should change > this reference to it to be orig.hash. Whoops -thanks. > > generic.py: > > - not sure I understand the purpose of this change (the comment change I > get). > we very occasionally publish unknown actions... that's a publication error, not a install one. > Missing change to TarBundle.py? > Weird - my workspace has it, but it didn't get picked up. Investigating... > t_pkg_install_basics.py: > > - It would be useful to have a test where you touch /tmp/libc.so.1 to > some other time than is in the timestamp and confirm that it fails > verification. > > We probably want to preserve timestamps on *all* .py files, or at least all > those which have .pyc files right next to them. Getting SUNWipkg is great, > but everything else would be better. You could do this in the Makefile if > you blindly did all .py files. The .py-only-if-.pyc bit would need logic > in solaris.py. Yes... that's the right answer. I was doing this in testing w/ EXTRA_OPTIONS; I'll add this to default invocation in Makefile. > > publish.py: > > - line 274: use the else clause on the for loop to do something when you > fall off the end, rather than breaking out: > > for pattern in files: > if fnmatch(...): > break > else: > del action.attrs["timestamp"] > cute; I forgot about that trick. Did it in solaris.py as well. - Bart -- Bart Smaalders Solaris Kernel Performance [EMAIL PROTECTED] http://blogs.sun.com/barts "You will contribute more with mercurial than with thunderbird." _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
