Tom Mueller (pkg-discuss) wrote:
> Issues:
> http://defect.opensolaris.org/bz/show_bug.cgi?id=856
> http://defect.opensolaris.org/bz/show_bug.cgi?id=1347
> http://defect.opensolaris.org/bz/show_bug.cgi?id=2307
>
> Webrev:
> http://cr.opensolaris.org/~tmueller/cr-856,1347,2307/
>
> These issues are for the image UUID and image properties features, plus
> a minor bug fix.
>
> After the comments that were received from previous code reviews and a
> discussion with Stephen about the UUID and image properties features,
> the following changes to the design have been implemented:
>
> Image properties:
> - replace policies with properties (policies are just boolean properties).
> - old policies are read from the cfg_cache file correctly and moved to
> the [property] section
> - since policies are now properties, policies will be able to be set
> using the pkg set-property command
>
> UUID:
> - A UUID is always set for each authority
> - A new image-wide policy, send-uuid, is introduced to control whether
> the UUIDs for authorities are sent. Default value: false.
> - The reset-uuid option is retained on set-authority to allow an
> installer or other software that copies an image to change the UUID.
>
> The changes have been merged with the current code. Since the fix for
> 1347 depends on the policy related fixes in 856, the changes are now
> together in a single webrev.
>
> The complete designs for these features have been put into the issues.
client.py:
- line 1430: drop spaces around '=' for PEP8
- line 1547: the comment seems a little off here?
pkg.5.txt:
- line 352, 356: two spaces needed after each '.'
image.py:
- line 342: Drop the space at the beginning of the docstring. Two
spaces after each '.' needed.
imageconfig.py:
- lines 41-45: I think our style is to drop the space before the ':'
- line 46: drop the spaces before '}'
- line 71: two spaces after '.'
- line 73: Move the """ down to the next line
misc.py:
There is a subtle Python behaviour here that I ran into that is
caused by our use of default values for arguments. Because we state
"headers = {}" in the function definition, X-IPkg-UUID will always be
sent the first time uuid is defined since the list is only assigned
once. As such, I suggest we change headers = {} to be headers = None
and set headers = {} explicitly inside the function itself if it is not
provided.
Cheers,
--
Shawn Walker
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
