Others also made comments about why it was win rather than windows. See
the comments in the issue.
I rewrote this change to use "windows" instead of all the win*
variants. The detail is not needed in the OS name because that
information is available from the release information that is put in the
User-Agent header. Also added in changes for another issue, 2907, to
add distro information to the linux value.
New webrev: http://cr.opensolaris.org/~tmueller/cr-2542,2907/
Issues:
http://defect.opensolaris.org/bz/show_bug.cgi?id=2542
http://defect.opensolaris.org/bz/show_bug.cgi?id=2907
Thanks.
Tom
Danek Duvall wrote:
On Thu, Aug 14, 2008 at 03:41:49PM -0500, Tom Mueller (pkg-discuss) wrote:
Webrev: http://cr.opensolaris.org/~tmueller/cr-2542/
Not that this matters for my platform of choice, but it seems like we're
calling platform.system().lower() and platform.release().lower() a heck of
a lot, rather than calling each one once and reusing the value.
Might be nice to clean that up a bit.
Otherwise, my only comment is: "win" and not "windows"?
I've also found that, at least on Solaris, Python execs uname to retrieve
this data. Ick. Not your problem here, but I think we might want to file
a bug to fix that.
Danek
begin:vcard
fn:Tom Mueller
n:Mueller;Tom
org:Sun Microsystems, Inc.;Update Center Software
adr:;;21915 Hillandale Dr;Elkhorn;NE;68022;USA
email;internet:[EMAIL PROTECTED]
title:Senior Staff Engineer
tel;work:877-250-4011
tel;fax:877-250-4011
tel;home:402-916-9943
x-mozilla-html:TRUE
version:2.1
end:vcard
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
