Good catch, I'll remove the quotes on 70. If you just run make test, or python setup.py test, then you'll never hit the if. The only case you'll hit the if is if you do python tests/run.py, which I forgot to test. Thanks for noticing that :)
I'll update the webrev in a bit. Thanks, Brad On Fri, Aug 15, 2008 at 07:15:55PM -0700, Brock Pytlik wrote: > Two quick questions. > > On line 70, should the quotes around testdir be there? > > Other question is under what conditions the test on line 69 will ever be > true. When I applied the patch, I wasn't able to make it enter the if > clause, even when running from */src. I tried both make test and python > setup.py test. If nothing else, I think I find the comment on line 68 > confusing. > > Other than that, it looks good to me. > > Brock > > Brad Hall wrote: > >Hi, > > > >Link to CR: http://cr.opensolaris.org/~bhall/bug-2782/ > >Link to BUG: http://defect.opensolaris.org/bz/show_bug.cgi?id=2782 > > > >The changes here just add a function find_tests() which replaces > >make_{cli,api}_tests(). In the old make*test() functions you had to > >specify > >all the test classes individually, with find_tests() you just specify the > >directory and it will auto-find all your test files (provided they match > >t_*.py (which all currently do)). > > > >Thanks, > >Brad > >_______________________________________________ > >pkg-discuss mailing list > >[email protected] > >http://mail.opensolaris.org/mailman/listinfo/pkg-discuss > > _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
