On Mon, Aug 18, 2008 at 11:21:28AM -0500, Shawn Walker wrote: > http://cr.opensolaris.org/~swalker/pkg-2905/
What's the point of setting fpath to None first? Perhaps the except statement should be more specific? (IndexError, IllegalDotSequence, IllegalVersion) I'm assuming, also, that we do the right thing when the file actually isn't on disk (as would happen when we give it a partial version)? serve_file() appears to throw a cherrypy.NotFound() exception, but does something on the other side of the stack handle that and return a 404 for us? I also wonder if, given that we wouldn't expect a malformed fmri to work, that perhaps 400 is a better response than 404? It's true we didn't find it, but not just because it wasn't there, but because it couldn't be there. We can change this later, if we decide to make the client handle that case more specifically, but it's something to think about. Thanks, Danek _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
