Brock, > http://cr.opensolaris.org/~bpytlik/ips-2672-v1/ > has the patch.
The code here looks okay to me. I still don't completely grasp what's going on in query_engine, but I did take a look at all the files. > Remote search takes the biggest hit, going from .1-.2 seconds to .6-.7 > seconds. For now, I think this is still acceptable. The time it takes > will grow with the number of new search tokens introduced. So this is between 6x and 3.5x slower? That seems like a large regression. I'm assuming case insensitive search is lumped into this number, but it's not entirely clear. How does this scale? You've said the time will grow with the number of tokens. Is the growth linear with respect to the number of tokens? It would be interesting to see at what point this gets painful. Have you run an experiment that would simulate a repository with a large number of builds, just to see how long we have before this becomes a serious issue? > If this becomes a performance issue in the future, there are several > possible optimizations that can be made on the server side. My choice > would be to essentially pre-build the case sensitive dictionary in > addition to the case-sensitive dictionary. Glad you know how to solve this problem when it shows up. ;) -j _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
