Hi, The following webrev is a pylint cleanup of the IPS GUI code I and Michal have done, based on Rich's gui_pylintrc, which is part of the webrev under src/tests/gui_pylintrc.
http://cr.opensolaris.org/~jmr/2735pylint_gui_cleanup_v4_Aug22 We still get a few warnings but these will go once we get rid of duplicated ips code. ************* Module installupdate W:523:InstallUpdate.__preexecute: Access to a protected member _PkgPlan__progtrack of a client class W:538:InstallUpdate.__preexecute: Used * or ** magic W:548:InstallUpdate.__preexecute: Access to a protected member _PkgPlan__progtrack of a client class ************* Module packagemanager W:1597:PackageManager.get_installed_version: Access to a protected member _get_version_installed of a client class We have pruned the suppressed warnings down to: # C0111: Missing Docstring # W0511: Used when a warning note as FIXME or XXX is detected. # W0613: Unused argument disable-msg=C0111,W0511,W0613 We copied over the [DESIGN] section from src/tests/pylintrc to be in sync with the rest of IPS. We had to make a few mods due to the nature of the GUI code for max-attributes, max-public-methods and max-module-lines (see below). JR # Maximum number of attributes for a class (see R0902). # Require large number of instance attributes as we are loading up handles to widget elements and only want to do this once in init # for performance reasons max-attributes=60 # Maximum number of public methods for a class (see R0904). # Increase from 20 to 40 as we are deriving off various classes and can't reduce the number further max-public-methods=40 # Maximum number of lines in a module # Increased from 1500 as the packagemanager is doing a lot of GUI initialization that we can't logically put anywhere else. max-module-lines=2000 _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
