Ok. If I make the name too long, it wraps off a bunch of lines. I've changed this to get_pkg_otw_size (get_package_over-the-wire_size). The docstring should be descriptive enough to help the morbidly curious.
Thanks, -j On Tue, Aug 26, 2008 at 05:29:06PM -0500, Shawn Walker wrote: > [EMAIL PROTECTED] wrote: > > Folks, > > Here's short code review that fixes a couple of bugs related to the > > download size. Now that we have pkg.csize, the compressed size, > > available, it is possible to use that to determine how much we'll > > actually download. These changes update the ProgressTracker and > > FileList to use pkg.csize, if it's available. > > > > Webrev is here: > > > > http://cr.opensolaris.org/~johansen/pkg-2556/ > > My only comment is that get_pkg_size is a bit ambiguous for a name. > While the docstring clarifies that it's really the compressed size (if > available), I'd be inclined to name the method "get_pkg_transfer_size" > or some such instead. > > Otherwise, your changes seem fine. > > Cheers, > -- > Shawn Walker > _______________________________________________ > pkg-discuss mailing list > [email protected] > http://mail.opensolaris.org/mailman/listinfo/pkg-discuss _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
