On Thu, Aug 28, 2008 at 06:57:29PM -0700, Brad Hall wrote: > Link to CR: http://cr.opensolaris.org/~bhall/bug-2056/
SolarisPackageDirBundle.py: - I'd skip the exists check, and just put the open in a try statement, passing if it doesn't exist. - It'd be nice to have something sane happen if cf is None by line 66, but we already have the issue that if the open fails, it stack traces, so maybe we don't fix this now. Looks nice, otherwise. If that was fun, you can tackle bug 350, too. :) Danek _______________________________________________ pkg-discuss mailing list pkg-discuss@opensolaris.org http://mail.opensolaris.org/mailman/listinfo/pkg-discuss