Hi all,

I'm looking for a review of the fix for bug #3243:

http://defect.opensolaris.org/bz/show_bug.cgi?id=3243
get_file_from_pkg.py should set PYTHONPATH

Webrev is at:

http://cr.opensolaris.org/~richb/pkg-3243-v1/

Fix involved copying the setup_environment() routine
from .../gate/src/tests/cli/testutils.py into
.../gate/src/util/distro-import/get_file_from_pkg.py
and slightly adjusting the initial comment and adjusting
an error message to be printed to stderr rather than stdout.

Tested by importing build 94 (what I had handy as a set of
unpacked WOS packages on my machine), and publishing them
to a local repository.

I note that the routine might be more generic that is needed
for this file. It's presumed that the Solaris import would
only happen on an OpenSolaris system. So if needed, the
platform tests against window, linux and darwin could be
removed. I didn't think that was necessary but as this is
my fix pkg bug fix, I'll take guidance from the experts.

Thanks.

_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to