On Wed, Sep 10, 2008 at 02:54:57PM -0500, Shawn Walker wrote: > elf.c: > line 326: if for some bizarre reason, PyErr_NewException returned > null here, couldn't that cause a seg fault? It would seem you want the > same check here as the one you have for Py_InitModule.
Yup. > Only one other comment: > Why use malloc/free directly instead of PyMem_Malloc, PyMem_Free? [1] I don't see the benefit, either. The explanation given doesn't really resonate with me. I'm happy to change it, but I'd like a clearer reason. Danek _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
