[EMAIL PROTECTED] wrote: > Brock, > In general this looks good. Just one nit. > > image.py 74-79: We've been putting a lot of the exceptions in misc.py. > Do you think you could either put this exception there, or create a new > file just for the excepitons? If you create a new file, would you move > the other ones in misc.py there? > > One the new API comes out, this exception will move to being an ApiException since it crosses the API boundary. If you'd prefer to have it live in misc.py until that happens, I'm fine with that.
Thanks for the review. Brock > Thanks, > > -j > > On Wed, Sep 10, 2008 at 03:31:57PM -0700, Brock Pytlik wrote: > >> Webrev at: >> http://cr.opensolaris.org/~bpytlik/ips-1540-v2/ >> >> Bugs at: >> changes to authorities should include refresh >> http://defect.opensolaris.org/bz/show_bug.cgi?id=1540 >> >> pkg image-update fails when unable to contact an authority >> http://defect.opensolaris.org/bz/show_bug.cgi?id=2886 >> >> install should attempt to refresh the catalogs before running >> http://defect.opensolaris.org/bz/show_bug.cgi?id=3121 >> >> all commands which automatically refresh catalogs should have a >> --dont-refresh flag >> http://defect.opensolaris.org/bz/show_bug.cgi?id=3122 >> >> >> This is the fix to make explicit refresh go away, at least for most >> operations. If there are some I've missed, please let me know and I'll >> either fix it or file additional bugs to pix up those in another batch. >> >> Brock >> _______________________________________________ >> pkg-discuss mailing list >> [email protected] >> http://mail.opensolaris.org/mailman/listinfo/pkg-discuss >> _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
