Hi all, I'm looking for a review of Dave Comay's fix for bug #2848:
http://defect.opensolaris.org/bz/show_bug.cgi?id=2848 build_entire_incorporation always created incorporation against latest build Webrev is at: http://cr.opensolaris.org/~richb/pkg-2848-v1/ Tested by creating a local repository and filling it with all the WOS packages for builds 94 and then 97. Here's what I used for build 97: #!/bin/ksh export ROOT=/export/home/richb/pkg/bugs/2848/gate/proto/root_i386 export PYTHONPATH=${ROOT}/usr/lib/python2.4/vendor-packages export REPO=http://localhost:29047/ export WOS_PKGS=/export/home/pkg-solaris/WOS_Packages/x/97/Solaris_11/Product/ export EXTRA_OPTIONS= (cd src/util/distro-import ; \ make -e clobber ; \ make -e 97/redist_import ) > errs.import 2>&1 & The end of the build 97 "redist_import" errs.import output showed: ... make 97/entire make BUILDID=97 entire ./build_entire_incorporation 97 > 97/entire.incorporation PKG_REPO=http://localhost:29047/ ./import_manifest_file [EMAIL PROTECTED],5.11-0.97 97/entire.incorporation PUBLISHED pkg:/[EMAIL PROTECTED],5.11-0.97:20080912T231158Z Looking at the package repository via http://stard.sfbay.sun.com:29047 I see: pkg:/[EMAIL PROTECTED],5.11-0.94:20080912T212156Z Info Manifest pkg:/[EMAIL PROTECTED],5.11-0.97:20080912T231158Z Info Manifest I then ran the build_entire_incorporation for build 94 with: #!/bin/ksh export ROOT=/export/home/richb/pkg/bugs/2848/gate/proto/root_i386 export PYTHONPATH=${ROOT}/usr/lib/python2.4/vendor-packages export REPO=http://localhost:29047/ export WOS_PKGS=/export/home/pkg-solaris/WOS_Packages/x/94/Solaris_11/Product/ export EXTRA_OPTIONS= (cd src/util/distro-import ; \ make -e 94/entire ) > errs.entire 2>&1 & The errs.entire output showed: make BUILDID=94 entire ./build_entire_incorporation 94 > 94/entire.incorporation PKG_REPO=http://localhost:29047/ ./import_manifest_file [EMAIL PROTECTED],5.11-0.94 94/entire.incorporation PUBLISHED pkg:/[EMAIL PROTECTED],5.11-0.94:20080912T235523Z Looking at the package repository again via http://stard.sfbay.sun.com:29047 I see the new "entire" package for build 94: pkg:/[EMAIL PROTECTED],5.11-0.94:20080912T212156Z Info Manifest pkg:/[EMAIL PROTECTED],5.11-0.94:20080912T235523Z Info Manifest pkg:/[EMAIL PROTECTED],5.11-0.97:20080912T231158Z Info Manifest _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
