Rich Burridge wrote:
> Hi all,
> 
> I'm looking for a review of the fix for bug #3244:
> 
>   http://defect.opensolaris.org/bz/show_bug.cgi?id=3244
>   Use of continuation lines in import file should be supported

solaris.py:

  934         lines = []
  935         complete = False
  936         while not complete:
  937                 line = lexer.instream.readline().strip()
  938                 if line[-1] in continuation:
  939                         line = line[:-1]
  940                 else:
  941                         complete = True
  942                 lines.append(line)
  943         return ' '.join(lines)

could more simply read:

lines = []
while True:
        line = lexer.instream.readline().strip()
        if line[-1] in continuation:
                lines.append(line[:-1])
        else:
                lines.append(line)
                break;
return ' '.join(lines)


-- 
Bart Smaalders                  Solaris Kernel Performance
[EMAIL PROTECTED]               http://blogs.sun.com/barts
"You will contribute more with mercurial than with thunderbird."
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to