On Tue 28 Oct 2008 at 05:49PM, Brock Pytlik wrote:
> Updated webrev at
> http://cr.opensolaris.org/~bpytlik/ips-2717-v2/
>
> It removes refresh-index and rebuild from the smf property list. It also
> cleans up a few typos in the ksh script and adjusted the man pages to
> reflect the changes.
Looks pretty good and much improved from last go round.
I found it a little confusing that $trans is used for short_option_props
and for long_option_props, but not for boolean_props. Perhaps for
consistency, it'd be better (and easier to maintain) if boolean props
were also passed through the $trans transformation?
Nuke comments that say '# Check that svcprop worked correctly.' -- your
audience knows what $? means.
Why is it that we're testing properties against "none" versus just being
set to the empty string? It seems like it will work, but I don't really
get the idiom.
In several places (64, 79, etc): it's --> its.
-dp
--
Daniel Price - Solaris Kernel Engineering - [EMAIL PROTECTED] - blogs.sun.com/dp
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
