Shawn, > client.py: > line 646-647: extraneous whitespace?
Deleted. Thanks. > general comment -- my personal preference is to see mirror stats show > up as a result of specifying "-v" for verbose instead of using > environment variables as an interface. Maybe use global_settings to > implement this through -v? If PKG_MIRROR_STATS constitutes a valid > interface, can you update pkg.1.txt? I originally had this written as a command line option to install and image-update; however, Stephen said that he preferred an environment variable. So, I changed it. I'm not sure if we want to make this a documented interface yet. > image.py: > line 439-440: Perhaps, "All mirrors in the chosen_set have already > been used; try the primary authority instead and reset the chosen_set to > reflect that." ? I've replaced the comment with a variation of this. > Isn't "primary authority" just the authority origin and the mirrors are > just mirrors? I don't know if we've agreed upon or codified the terminology for this. > imageconfig.py: > line 181: what effect will this have on existing pkg clients? The > first time we read their imageconfig, will it still pick the authority > first and after that not? These are in-memory objects. I'm not exactly sure what you're asking, but this shouldn't have any effect on existing clients. -j _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
