Danek Duvall wrote: > On Thu, Nov 06, 2008 at 05:57:19PM -0800, Brock Pytlik wrote: > > >> http://cr.opensolaris.org/~bpytlik/ips-4570-v1/ >> > > testutils.py: > > - line 315: please remove the spaces surrounding the equals signs in this > line, since you're adding a parameter here anyway. > > Ok > - One thing to consider here would be to allow su_wrap to be True, which > would signal a generic "low permissions" user, in addition to a > specific user passed in as a string. > Ok > - line 323, 325: I think you want to remove the spaces after su_wrap and > before su_end. It shouldn't make a difference, but it'll be cleaner. > Ok > Danek >
_______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
