[EMAIL PROTECTED] wrote: >> I'm looking for a review of the fix for bug #4608: >> >> http://defect.opensolaris.org/bz/show_bug.cgi?id=4608 >> Missing icon for Java configuration tool >> >> Webrev is at: >> >> http://cr.opensolaris.org/~richb/pkg-4608-v1/ > > Looks OK although I have two nits: > > 1) I've been using the convention of using a single tab > character for continuation lines in the import files, as in > > add driver name=something \ > alias=etc,etc > > 2) Within each of the blocks, could these be sorts by "path"?
Okay. So changed. I also adjusted the use of continuation lines for the three .desktop files in a similar way, in the same two package files. >> >> >> Is there something else I need to do to get the icons to be immediately >> available? > > Did your testing including Bart's fix for 4660? You may be running > into an issue where the service doesn't detect these new icons because > they're being linked rather than copied. > > If that's the case, I don't think that needs to be fixed as part of > this bug but it would be good to check in any case. Yup, that was it. I needed to republish the package to my local repository. The new utterance of the solaris.py script also included the command line options: -G fonts -G gnome New webrev at: http://cr.opensolaris.org/~richb/pkg-4608-v2/ Thanks. _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
