Looks good to me, though I think:
563 + gobject.idle_add(self.update_statusbar)
Is not required as the status bar text is not being updated at this
time. It does need to be done as part of 4852, but as you say we are
only extracting the bits here to get the search performance improvement
for RC 1 1/2. You might want to put in a more descriptive define for
PM_TYPE_AHEAD_DELAY = 300 explaining that this will ensure if a user is
typing faster than 300 msec only the last search will be executed when
they stop typing.
JR
Michal Pryc wrote:
> Hi,
> I did modify a little bit webrev[0] made by Padraig to not introduce new
> string message as the localization team asked for the string freeze for
> 2008.11 and the webrev is at:
>
> http://cr.opensolaris.org/~migi/11_10_2008_bug_4852_v1/
>
> I would like to push this to the gate Today, as Tomorrow is the build
> for RC1 1/5.
>
> Also I did run the tests and pylint.
>
> The bug description tells more about concept of this change.
> http://defect.opensolaris.org/bz/show_bug.cgi?id=4852
>
> best
> Michal
>
> [0] http://cr.opensolaris.org/~padraig/2737_v1_Nov7/
> _______________________________________________
> pkg-discuss mailing list
> [email protected]
> http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
>
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
