Good point. Fixed per your comment.  New webrev is here:

http://cr.opensolaris.org/~tmueller/cr-4883-2/

Thanks.
Tom


Danek Duvall wrote:
> On Thu, Nov 13, 2008 at 03:12:21PM -0600, Tom Mueller (pkg-discuss) wrote:
>
>   
>> Webrev: http://cr.opensolaris.org/~tmueller/cr-4883/
>>     
>
> The downside of using this particular placement is that now this class has
> "pkg.pspawn", "posix_spawnp", and "SpawnFileAction" in its class
> dictionary, which seems wrong.  Is there any reason that you didn't just
> put another if statement back at the top?  (Module namespace clutter seems
> ubiquitous, if also a bit ugly.)
>
> Danek
>   

_______________________________________________
pkg-discuss mailing list
pkg-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to