[EMAIL PROTECTED] wrote: >> Webrev: >> http://cr.opensolaris.org/~bpytlik/ips-2701-v1/ >> > > server/catalog.py: > > - lines 134-137: Perhaps it would make sense to set a > default_index_root in this class. Then if index_root isn't > initialized, set index root to default. This means that you don't > have to go through all of the norpath/join gyrations that this code > currently uses. You can simply say: > > if self.index_root != self.default_index_root: > <pass extra argument to indexing process> > Well, as far as I can tell, I'd just have to move the gyrations up into the __init__ function or pass in a default_index_root from the config as well as the index_root, which seems silly. But, my brain my be fried enough that I'm not seeing the obvious solutions anymore. The default index root is based off of whatever the repo_root is set to. So doing the join and comparison seems inevitable. One thing I considered was having server config provide a function which generates the default index root, but I'm not sure what would work given the current structure of the code. > feed.py: > > If you have a writeable scratch area, shouldn't you be able to save the > feed information there instead of continuing to re-generate it every > time a client looks at the feed? I see a bunch of if scfg.is_read_only() > checks that don't have any associated logic for dealing with the > possibility that you may be able to write somewhere else. How is this > being handled? > Yeah, that was the reason I said not to bother at the first pass, I realized this was broken.
Thanks for taking a look, if I think of a good solution to the first issue I'll put it in. Brock > Thanks, > > -j > _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
