> Are we ever going to run this on anything but an OpenSolaris platform? :-)

I'm not sure.  Even if this ends up being a single platform script, the
os.path is used in other parts of the code.  It can't hurt to be
consistent.

> > Given that, I might make the following changes.
> >
> > 49: use os.path.curdir instead of "."
> > 74: use os.path.sep instead of "/"
> 
> Okay. So changed.

Thanks.

> New webrev at:
> 
>   http://cr.opensolaris.org/~richb/pkg-5292-v2/

Looks good.

-j
_______________________________________________
pkg-discuss mailing list
pkg-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to