On Mon, Nov 24, 2008 at 01:59:43AM -0600, Shawn Walker wrote:
> Greetings,
>
> The following webrev contains changes for the following RFEs:
> 3011 new depot index page desired
> 3014 revamped depot bui (web ui) desired
>
> webrev:
> http://cr.opensolaris.org/~swalker/pkg-3014/
catalog.py:
- line 870, 871: since you're making mods here, ditch the spaces around
the equals signs.
- line 918, 940: since you're defining these functions within the context
of another function, you don't have to make parameters out of the
things that won't actually change between calls, like constraint and
counthash. Indeed, versions and patterns probably don't need to be
passed in, either.
server/api.py:
- line 72: I'd drop the gen_ prefix. Especially as you don't always
return a generator (see line 78).
- In general, this looks nice, though I'd question why this is being done
as a separate module, rather than massaging the underlying modules to
do the right thing. Adding a layer to fix problems in lower layers is
wrong. I suppose it's just a matter of running out of time?
server/api_errors.py:
- line 47: Wouldn't the old and new URLs be useful / interesting data to
store here? Perhaps not yet.
face.py:
- line 84: since this is a security-critical portion of the app, please
make sure there is a test to prevent this from breaking.
Why is there a trailing backslash after all "%>"? Is that simply to avoid
having zillions of empty lines?
Is there a standard way for editors to recognize a file as a mako template?
Danek
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
