Rich Burridge wrote: > Darren J Moffat wrote: >>> I'm looking for a review of the fix for bug #5390: >>> >>> http://defect.opensolaris.org/bz/show_bug.cgi?id=5390 >>> SUNWsmbskr should be installed when SUNWsmbs is installed >>> >>> Webrev is at: >>> >>> http://cr.opensolaris.org/~richb/pkg-5390-v1/ >>> >> >> That certainly solves the problem I reported but I'm personally not >> convinced this fix scales. >> >> I think the root cause here is that SUNWsmbs was created by importing >> SUNWsmbr and SUNWsmbu but ignoring the dependencies the SRV4 files >> already had, right? > > The solaris.py script that imports these packages certainly does ignore > the SVR4 dependencies found in the .../install/depend files. > > See bug #5268 as a way of trying to better handle this. > http://defect.opensolaris.org/bz/show_bug.cgi?id=5268 > > This is a separate issue and hopefully you'll agree that it should be > handled separate from the fix for this bug (#5390).
Agreed this bug doesn't need to fix it if there is another one open for that. I just wanted to be sure I understood how we got here so that I know my review of your changes is based on sound understanding of the problem. -- Darren J Moffat _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
