Hi Brock,
> Webrev:
> http://cr.opensolaris.org/~bpytlik/ips-5212-v1/
client/query_engine.py:
- line 124: Is this assert safe? The documentation for readline()
seems to imply that it's entirely valid to get a '\n' as your
string.
readline([size])
Read one entire line from the file. A trailing newline
character is kept in the string (but may be absent when
a file ends with an incomplete line).
http://www.python.org/doc/2.4.4/lib/bltin-file-objects.html
Everthing else looks fine to me.
Thanks,
-j
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
