The icon PM_app_48x.png referred to in the glade file needs to be in 
data directory.

The icon packagemanager.png is used by desktop file.

We need both.

Padraig

On 12/04/08 14:51, jmr wrote:
> Padraig few comments:
>
> Why are you copying and renaming the png, just delete it from the repo 
> and put it back in with the new name.
>
> 141  149       150 +data/packagemanager.png: data/PM_app_48x.png
>      151 +        cp data/PM_app_48x.png data/packagemanager.png
>      152 +
> 142  153  PWD:sh = pwd
>
>
> As above I would rename this to the updatemanager.png in the repo
>
> 136      -        144 +
>      145 +data/updatemanager.png: data/PM_app_48x.png
>      146 +        cp data/PM_app_48x.png data/updatemanager.png
>
> JR
>
> Padraig O'Briain wrote:
>> The webrev http://cr.opensolaris.org/~padraig/ips-3931-v2/ fixes part of
>> bug 3931 Icons installed in wrong locations, with wrong names
>>
>> It changes the desktop files so that the Icon specification does not 
>> include the full pathname or suffix.
>>
>> Padraig
>> _______________________________________________
>> pkg-discuss mailing list
>> [email protected]
>> http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
>>   
>
_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to