On Thu, Dec 04, 2008 at 10:53:14AM -0800, Brad Hall wrote: > On Thu, Dec 04, 2008 at 03:26:53PM +0000, Padraig O'Briain wrote: > > New webrev http://cr.opensolaris.org/~padraig/ips-5069-v3 created, > > > > This will allow for https:// > > > > Padraig > > > > On 12/04/08 14:57, jmr wrote: > > > Padraig - this looks great and really improves the usability of the > > > dialog. > > > > > > In repository.py: > > > > > > 301 + if not misc.valid_auth_url(name): > > > 302 + if "http://".startswith(name): > > > 303 + self.url_error = None > > > Should you not also be allowing https:// as a valid start for a repo url? > > > > > > JR > > Maybe I'm missing something but isn't this check backwards? Shouldn't > it be name.startswith("http://";)?
Sorry, nevermind, I get it now. The check is valid it's just a little awkward when reading it. Maybe you can add a comment for clarity? Thanks, Brad _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
