Looks fine, just checked it and works fine for me. It will be removed when I land the work for the StoreFront feature.
JR Michal Pryc wrote: > Hi John, > I've changed method to set_visible* since this will never show the > icon even if someone will call show_all in the code somewhere else. > Another approach is to use after hide() the function > set_no_show_all(False), then the widget will not react on show_all > signal from underlying widget. > > New webrev: > > http://cr.opensolaris.org/~migi/05_12_2008_bug5064_v2/ > > best > Michal > > jmr wrote: >> Michal - thanks but you need to hide the icon after doing the show all >> in packagemanager.py init, so this needs changed back. >> >> JR >> >> Michal Pryc wrote: >>> Padraig, >>> Some icons were mising, so I've added them on top of your: >>> >>> http://cr.opensolaris.org/~padraig/ips-5064-v2/ >>> >>> The new webrev: >>> I didn't modify the glade file itself, but packagemanager.py (moved two >>> lines a little bit up) and I've added new icons together with modified >>> makefiles: >>> >>> http://cr.opensolaris.org/~migi/04_12_2008_bug5064_v1/ >>> >>> >>> best >>> Michal >>> >>> Padraig O'Briain wrote: >>> >>>> I have reworked the webrev so that the changes include some of the >>>> initial GUI changes for 2009.04. >>>> >>>> The new webrev is at http://cr.opensolaris.org/~padraig/ips-5188-v3/ >>>> >>>> It is important to get this change landed as GUI changes need to be >>>> done >>>> serially because of the difficulty in merging changes to the glade >>>> file. >>>> >>>> Padraig >>>> >>>> On 12/01/08 08:36, Padraig O'Briain wrote: >>>> >>>>> The webrev, http://cr.opensolaris.org/~padraig/ips-5064-v1/, fixes >>>>> bug 5064 The buttons are missing icons. >>>>> >>>>> The changes to the glade file adds icons to buttons and removes the >>>>> separators between the buttons at the bottom of the dialogs and >>>>> the rest >>>>> of the dialogs. >>>>> _______________________________________________ >>>>> pkg-discuss mailing list >>>>> [email protected] >>>>> http://mail.opensolaris.org/mailman/listinfo/pkg-discuss >>>>> >>>>> >>>> _______________________________________________ >>>> pkg-discuss mailing list >>>> [email protected] >>>> http://mail.opensolaris.org/mailman/listinfo/pkg-discuss >>>> >>> _______________________________________________ >>> pkg-discuss mailing list >>> [email protected] >>> http://mail.opensolaris.org/mailman/listinfo/pkg-discuss >>> >> >> _______________________________________________ >> pkg-discuss mailing list >> [email protected] >> http://mail.opensolaris.org/mailman/listinfo/pkg-discuss > _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
