Hi Tom, The second version of this code looks a lot better. Thanks for fixing this.
-j On Thu, Dec 11, 2008 at 08:20:04AM -0600, Tom Mueller (pkg-discuss) wrote: > Here is an updated webrev for the fixes for issue 4314 - providing > support for proxies for https connections. > > Webrev: http://cr.opensolaris.org/~tmueller/cr-4314-2 > > Thanks. > Tom > > Tom Mueller (pkg-discuss) wrote: > > Please review this fix for issue 4314: https proxy does not work > > > > Webrev: http://cr.opensolaris.org/~tmueller/cr-4314/ > > > > The fix is to introduce an HTTPSProxyHandler that works along side the > > HTTPSCertHandler. The former takes care of sending the CONNECT > > request to the proxy, with user authentication if needed. The latter > > is modified to deal with a connection if it already exists (in the > > case of the proxy). Otherwise it works as before. The modification > > to misc.py is to include the HTTPSProxyHandler for SSL requests. > > > > An SSL proxy is specified similarly to a regular proxy: > > > > https_proxy=http://webcache.sfbay:8080/ > > > > Note the "https" rather than "http". User authentication for the > > proxy looks like this: > > > > https_proxy=http://username:[email protected]:port/ > > > > I understand that this is throw-away code given that the pycurl > > implementation for the transport layer is coming. However, the SWI > > team needs this sooner rather than later, and it may actually be > > helpful for OpenSolaris too until the pycurl implementation is done. > > > > Thanks. > > Tom > > > > > > _______________________________________________ > pkg-discuss mailing list > [email protected] > http://mail.opensolaris.org/mailman/listinfo/pkg-discuss _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
