Tom Mueller wrote: > Shawn, > Very nice doc. Please consider these comments. > > line 16. Is it really HTTP/1.1 only? It seems to process HTTP/1.0 just > fine. Maybe than line isn't meant to say that it is 1.1 only.
It doesn't that it's 1.1 only, but I suppose it could be seen as implying that. > line 87, 90, 94: all of these modes allow depot operations too, right? Changed. > line 105: isn't the hash of the file content rather than the file name? Hrm, I misread the code comment for file_0: """ The request is the SHA-1 hash name for the file. The contents of the file is output directly to the client. """ However, you're right, it should be the hash of the (uncompressed?) content, not the filename. > General - it might be helpful to state that the FMRIs are URL-encoded in > the URLs and in other places such as in POST data. I see that this is > already done on line 365. Changed. I'm going to add a few more things to the doc and then re-post. Thanks, -- Shawn Walker _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
