Padraig O'Briain wrote:
> Some comments:
>
> 1) Is the latest version and installed version correct?
> On my system I have packages which are installed which have updates. The
> installed version and the latest version are reported as the same which
> does not look correct.

I've asked xDesign what we should show to the user in this field, so 
awaiting the answare.

> 2) For some packages the Summary and Category are empty. An example is
> FSWxorg-fonts. Is this outside your control?

The same, awaiting xDesign to response.

> 3) In the webrev in _show_package_info there are some lines added which
> are commented out. Should these lines be removed?
1174-1179, yest they should be removed.

> 4) Is the change near line 1900 to fix 4960.
yes. It's the background process for getting manifests to get 
descriptions from them, so if something goes wrong we are silently 
continuing.

I found another bug which should be solved together with this webrev: 
5663, but I didn't include this bug:
http://defect.opensolaris.org/bz/show_bug.cgi?id=5663
"gui cuts off long package descriptions, even in the detailed view"

This webrev will show the full description(summary).

best
Michal



>
> Padraig
>
> On 01/05/09 15:45, Michal Pryc wrote:
>> Hello and HAPPY NEW YEAR!
>>
>> Here is my first CR in 2009:
>>
>> http://cr.opensolaris.org/~migi/5665_4960_v1/
>>
>> Bugs: 5665 and 4960
>>
>> best
>> Michal Pryc

_______________________________________________
pkg-discuss mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/pkg-discuss

Reply via email to