I received feedback from Laca in the bug report on this. See: http://defect.opensolaris.org/bz/show_bug.cgi?id=6109#c6
Based on this, I've added the dependency to the SUNWgnome-base-libs IPS package. New webrev at: http://cr.opensolaris.org/~richb/pkg-6109-v2/ Thanks. -------- Original Message -------- Subject: Re: [pkg-discuss] Code review request for opensolaris bug #6109 Date: Fri, 16 Jan 2009 14:36:30 -0800 From: Rich Burridge <[email protected]> To: David Powell <[email protected]> CC: pkg discuss <[email protected]>, Brian Cameron <[email protected]> Thanks Dave. I did a little more research on this. The original SUNWgnome-base-libs WOS SVR4 package (for build #105) has the following lines in it's depend file: P SUNWcar Core Architecture, (Root) P SUNWkvm Core Architecture, (Kvm) P SUNWcsr Core Solaris, (Root) P SUNWcsu Core Solaris, (Usr) P SUNWcsd Core Solaris Devices P SUNWcsl Core Solaris, (Shared Libs) P SUNWgnome-base-libs-root GNOME base GUI libraries - / filesystem P SUNWxwxft Xft (X Freetype) Library P SUNWxwrtl X Window System & Graphics Runtime Library Links in /usr/lib P SUNWxwplt X Window System platform software P SUNWxorg-clientlibs X.Org Foundation X Client Libraries P SUNWlibms Math & Microtasking Libraries (Usr) P SUNWlxml The XML library P SUNWfreetype2 FreeType2 Font library P SUNWfontconfig Fontconfig library P SUNWlibpopt Command line parsing library P SUNWpng Portable Network Graphics library P SUNWTiff libtiff - library for reading and writing TIFF P SUNWjpg jpeg - The Independent JPEG Groups JPEG software P SUNWPython The Python interpreter, libraries and utilities P SUNWmlib mediaLib - Shared Libraries P SUNWpostrun Delayed execution environment for procedural package scripts P SUNWperl584core Perl 5.8.4 (core) P SUNWuiu8 Iconv modules for UTF-8 Locale (You'll notice SUNWuiu8 as the last one). The IPS package definition for the SUNWgnome-base-libs doesn't have any depend lines. The automatic dependancy checker in the solaris.py script picks up the following: $ pkg contents -m SUNWgnome-base-libs | grep depend depend [email protected] type=require depend [email protected] type=require depend [email protected] type=require depend [email protected] type=require depend [email protected] type=require depend [email protected] type=require depend [email protected] type=require depend [email protected] type=require depend [email protected] type=require depend [email protected] type=require depend [email protected] type=require depend [email protected] type=require depend [email protected] type=require depend [email protected] type=require depend [email protected] type=require depend [email protected] type=require depend [email protected] type=require So it would appear the the: depend SUNWuiu8 line should be added to the SUNWgnome-base-libs IPS package definition. And maybe some others... Adding Brian (one of our resident GNOME experts) to the cc: for his opinion. -------- Original Message -------- Subject: Re: [pkg-discuss] Code review request for opensolaris bug #6109 Date: Fri, 16 Jan 2009 13:45:08 -0800 From: David Powell <[email protected]> To: Rich Burridge <[email protected]> CC: pkg discuss <[email protected]> References: <[email protected]> Rich Burridge wrote: > Hi all, > > I'm looking for a review of the fix for bug #6109: > > http://defect.opensolaris.org/bz/show_bug.cgi?id=6109 > gconf-cache:default unable to convert ASCII<->UTF-8, fails > > Webrev is at: > > http://cr.opensolaris.org/~richb/pkg-6109-v1/ > > It's a simple change. The fix was also manually tested by the > original bug submitter (see the comments to bug #6109). As I suggested in the bug report, it is probably the case that the dependency belongs to SUNWgnome-config, not SUNWdesktop-cache. AFAIK, any caller to gconftool-2 will encounter this problem. Adding the dependency to SUNWdesktop-cache only helps that consumer of gconftool-2, whereas adding it to SUNWgnome-config would help all consumers. That said, it might be that an even more upstream package that has the real dependency. In particular, the error message in question appears to have originated from GLib, which is shipped in SUNWgnome-base-libs. I recommend talking to a gnome expert. Dave _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
