> The webrev http://cr.opensolaris.org/~padraig/ips-6268-v1/ fixes > 6268 PackageManager does not work with latest ips code > > The change to call to get_manifest is necessary because of changes in > changeset 838. > The change to TransportFailures is to specify where it comes from.
If you pass on the TransportFailures exception, you're not reporting any failure information to the user. What happens when the manifest isn't successfully retrieved due to transient network errors? The second thing is that this code is continuing to use the image object. The API was designed so that the GUI wouldn't manipulate the image object directly. If you're depending upon behavior in the image object, you'll potentially get broken by an unknown number of changes. If there's functionality that's missing from the API, you should file a bug against the API instead of using the image object directly. -j _______________________________________________ pkg-discuss mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/pkg-discuss
